mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-19 15:10:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

missed the obvious test case and corresponding fix

Browse source
This commit is contained in:
Skip Montanaro 2004-09-14 17:55:21 +00:00
parent 1fd00a1b71
commit cae14d2714
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/httplib.py
View file

@ -525,7 +525,8 @@ class HTTPConnection:
def _set_hostport(self, host, port): def _set_hostport(self, host, port):
if port is None: if port is None:
i = host.rfind(':') i = host.rfind(':')
if i >= 0: j = host.rfind(']') # ipv6 addresses have [...]
if i > j:
try: try:
port = int(host[i+1:]) port = int(host[i+1:])
except ValueError: except ValueError:

2
Lib/test/test_httplib.py
View file

@ -119,7 +119,7 @@ def _test():
print "Expect InvalidURL" print "Expect InvalidURL"
for hp in ("[fe80::207:e9ff:fe9b]:8000", "www.python.org:80", for hp in ("[fe80::207:e9ff:fe9b]:8000", "www.python.org:80",
"www.python.org"): "www.python.org", "[fe80::207:e9ff:fe9b]"):
try: try:
h = httplib.HTTP(hp) h = httplib.HTTP(hp)
except httplib.InvalidURL: except httplib.InvalidURL: