mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-13 15:40:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Raise ValueError when attempting to set the _CHUNK_SIZE attribute of a TextIOWrapper to a huge value, not TypeError.

Browse source
This commit is contained in:
Antoine Pitrou 2011-07-13 21:07:49 +02:00
parent fd060474e3
commit cb4ae815b5
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Misc/NEWS
View file

@ -27,6 +27,9 @@ Core and Builtins
Library Library
------- -------
- Raise ValueError when attempting to set the _CHUNK_SIZE attribute of a
TextIOWrapper to a huge value, not TypeError.
- Issue #12493: subprocess: Popen.communicate() now also handles EINTR errors - Issue #12493: subprocess: Popen.communicate() now also handles EINTR errors
if the process has only one pipe. if the process has only one pipe.

2
Modules/_io/textio.c
View file

@ -2556,7 +2556,7 @@ textiowrapper_chunk_size_set(textio *self, PyObject *arg, void *context)
{ {
Py_ssize_t n; Py_ssize_t n;
CHECK_INITIALIZED_INT(self); CHECK_INITIALIZED_INT(self);
n = PyNumber_AsSsize_t(arg, PyExc_TypeError); n = PyNumber_AsSsize_t(arg, PyExc_ValueError);
if (n == -1 && PyErr_Occurred()) if (n == -1 && PyErr_Occurred())
return -1; return -1;
if (n <= 0) { if (n <= 0) {