mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-127371 Avoid unbounded growth SpooledTempfile.writelines (GH-127372)

Browse source
This commit is contained in:
Bert Peters 2025-03-04 23:06:07 +01:00 • committed by GitHub
parent 691354ccb0
commit cb67b44ca9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 39 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Lib/test/test_tempfile.py
View file

@ -1284,6 +1284,34 @@ class TestSpooledTemporaryFile(BaseTestCase):
buf = f.read()
self.assertEqual(buf, b'xyz')
def test_writelines_rollover(self):
# Verify writelines rolls over before exhausting the iterator
f = self.do_create(max_size=2)
def it():
yield b'xy'
self.assertFalse(f._rolled)
yield b'z'
self.assertTrue(f._rolled)
f.writelines(it())
pos = f.seek(0)
self.assertEqual(pos, 0)
buf = f.read()
self.assertEqual(buf, b'xyz')
def test_writelines_fast_path(self):
f = self.do_create(max_size=2)
f.write(b'abc')
self.assertTrue(f._rolled)
f.writelines([b'd', b'e', b'f'])
pos = f.seek(0)
self.assertEqual(pos, 0)
buf = f.read()
self.assertEqual(buf, b'abcdef')
def test_writelines_sequential(self):
# A SpooledTemporaryFile should hold exactly max_size bytes, and roll
# over afterward