mirror of
https://github.com/python/cpython.git
synced 2025-07-28 21:55:21 +00:00
Issue #1068268: The subprocess module now handles EINTR in internal
os.waitpid and os.read system calls where appropriate.
This commit is contained in:
parent
fb501123e3
commit
cce211f88c
3 changed files with 38 additions and 4 deletions
|
@ -476,6 +476,16 @@ PIPE = -1
|
|||
STDOUT = -2
|
||||
|
||||
|
||||
def _eintr_retry_call(func, *args):
|
||||
while True:
|
||||
try:
|
||||
return func(*args)
|
||||
except OSError, e:
|
||||
if e.errno == errno.EINTR:
|
||||
continue
|
||||
raise
|
||||
|
||||
|
||||
def call(*popenargs, **kwargs):
|
||||
"""Run command with arguments. Wait for command to complete, then
|
||||
return the returncode attribute.
|
||||
|
@ -1173,13 +1183,14 @@ class Popen(object):
|
|||
os.close(errwrite)
|
||||
|
||||
# Wait for exec to fail or succeed; possibly raising exception
|
||||
data = os.read(errpipe_read, 1048576) # Exception limited to 1M
|
||||
# Exception limited to 1M
|
||||
data = _eintr_retry_call(os.read, errpipe_read, 1048576)
|
||||
finally:
|
||||
# be sure the FD is closed no matter what
|
||||
os.close(errpipe_read)
|
||||
|
||||
if data != "":
|
||||
os.waitpid(self.pid, 0)
|
||||
_eintr_retry_call(os.waitpid, self.pid, 0)
|
||||
child_exception = pickle.loads(data)
|
||||
for fd in (p2cwrite, c2pread, errread):
|
||||
if fd is not None:
|
||||
|
@ -1215,7 +1226,7 @@ class Popen(object):
|
|||
"""Wait for child process to terminate. Returns returncode
|
||||
attribute."""
|
||||
if self.returncode is None:
|
||||
pid, sts = os.waitpid(self.pid, 0)
|
||||
pid, sts = _eintr_retry_call(os.waitpid, self.pid, 0)
|
||||
self._handle_exitstatus(sts)
|
||||
return self.returncode
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue