mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-17 22:20:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

more build_clib cleanup + test coverage

Browse source
This commit is contained in:
Tarek Ziadé 2009-05-06 08:05:47 +00:00
parent b04a05709d
commit ccf608c94c
2 changed files with 60 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Lib/distutils/command/build_clib.py
View file

@ -86,7 +86,7 @@ class build_clib (Command):
if self.include_dirs is None:
self.include_dirs = self.distribution.include_dirs or []
if type(self.include_dirs) is StringType:
if isinstance(self.include_dirs, str):
self.include_dirs = string.split(self.include_dirs,
os.pathsep)
@ -170,8 +170,7 @@ class build_clib (Command):
filenames = []
for (lib_name, build_info) in self.libraries:
sources = build_info.get('sources')
if (sources is None or
type(sources) not in (ListType, TupleType) ):
if sources is None or not isinstance(sources, (list, tuple)):
raise DistutilsSetupError, \
("in 'libraries' option (library '%s'), "
"'sources' must be present and must be "
@ -183,7 +182,7 @@ class build_clib (Command):
def build_libraries (self, libraries):
for (lib_name, build_info) in libraries:
sources = build_info.get('sources')
if sources is None or type(sources) not in (ListType, TupleType):
if sources is None or not isinstance(sources, (list, tuple)):
raise DistutilsSetupError, \
("in 'libraries' option (library '%s'), " +
"'sources' must be present and must be " +