mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-17 12:18:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

ttk: fix LabeledScale and OptionMenu destroy() method (#3025)

Browse source 
bpo-31135: Call the parent destroy() method even if the used
attribute doesn't exist.

The LabeledScale.destroy() method now also explicitly clears label
and scale attributes to help the garbage collector to destroy all
widgets.
This commit is contained in:
Victor Stinner 2017-08-08 19:41:21 +02:00 • committed by GitHub
parent 733d0f63c5
commit cd7e9c1b67
2 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Lib/tkinter/ttk.py
View file

@ -1543,11 +1543,12 @@ class LabeledScale(Frame):
try: try:
self._variable.trace_vdelete('w', self.__tracecb) self._variable.trace_vdelete('w', self.__tracecb)
except AttributeError: except AttributeError:
# widget has been destroyed already
pass pass
else: else:
del self._variable del self._variable
Frame.destroy(self) super().destroy()
self.label = None
self.scale = None
def _adjust(self, *args): def _adjust(self, *args):
@ -1644,5 +1645,8 @@ class OptionMenu(Menubutton):
def destroy(self): def destroy(self):
"""Destroy this widget and its associated variable.""" """Destroy this widget and its associated variable."""
del self._variable try:
Menubutton.destroy(self) del self._variable
except AttributeError:
pass
super().destroy()

4
Misc/NEWS.d/next/Library/2017-08-08-14-44-37.bpo-31135.HH94xR.rst Normal file
View file

@ -0,0 +1,4 @@
ttk: fix the destroy() method of LabeledScale and OptionMenu classes.
Call the parent destroy() method even if the used attribute doesn't
exist. The LabeledScale.destroy() method now also explicitly clears label and
scale attributes to help the garbage collector to destroy all widgets.