mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-02 16:13:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

[3.13] gh-121571: Do not use EnvironmentError in tests, use OSError instead (GH-121572) (#121574)

Browse source 
gh-121571: Do not use `EnvironmentError` in tests, use `OSError` instead (GH-121572)
(cherry picked from commit e2822360da)

Co-authored-by: sobolevn <mail@sobolevn.me>
This commit is contained in:
Miss Islington (bot) 2024-07-10 12:38:48 +02:00 • committed by GitHub
parent 35c9399078
commit ced3fe87b0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/support/__init__.py
View file

@ -388,7 +388,7 @@ def skip_if_buildbot(reason=None):
reason = 'not suitable for buildbots' reason = 'not suitable for buildbots'
try: try:
isbuildbot = getpass.getuser().lower() == 'buildbot' isbuildbot = getpass.getuser().lower() == 'buildbot'
except (KeyError, EnvironmentError) as err: except (KeyError, OSError) as err:
warnings.warn(f'getpass.getuser() failed {err}.', RuntimeWarning) warnings.warn(f'getpass.getuser() failed {err}.', RuntimeWarning)
isbuildbot = False isbuildbot = False
return unittest.skipIf(isbuildbot, reason) return unittest.skipIf(isbuildbot, reason)

2
Lib/test/test_subprocess.py
View file

@ -1407,7 +1407,7 @@ class ProcessTestCase(BaseTestCase):
t = threading.Thread(target=open_fds) t = threading.Thread(target=open_fds)
t.start() t.start()
try: try:
with self.assertRaises(EnvironmentError): with self.assertRaises(OSError):
subprocess.Popen(NONEXISTING_CMD, subprocess.Popen(NONEXISTING_CMD,
stdin=subprocess.PIPE, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stdout=subprocess.PIPE,