mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-15 22:30:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Merged revisions 78638 via svnmerge from

Browse source 
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r78638 | victor.stinner | 2010-03-04 00:20:25 +0100 (jeu., 04 mars 2010) | 3 lines

  Issue #7544: Preallocate thread memory before creating the thread to avoid a
  fatal error in low memory condition.
........
This commit is contained in:
Victor Stinner 2010-03-21 13:32:31 +00:00
parent 27bf15ef8d
commit d156fa3033
4 changed files with 38 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Include/pystate.h
View file

@ -105,6 +105,8 @@ PyAPI_FUNC(void) PyInterpreterState_Clear(PyInterpreterState *);
PyAPI_FUNC(void) PyInterpreterState_Delete(PyInterpreterState *); PyAPI_FUNC(void) PyInterpreterState_Delete(PyInterpreterState *);
PyAPI_FUNC(PyThreadState *) PyThreadState_New(PyInterpreterState *); PyAPI_FUNC(PyThreadState *) PyThreadState_New(PyInterpreterState *);
PyAPI_FUNC(PyThreadState *) _PyThreadState_Prealloc(PyInterpreterState *);
PyAPI_FUNC(void) _PyThreadState_Init(PyThreadState *);
PyAPI_FUNC(void) PyThreadState_Clear(PyThreadState *); PyAPI_FUNC(void) PyThreadState_Clear(PyThreadState *);
PyAPI_FUNC(void) PyThreadState_Delete(PyThreadState *); PyAPI_FUNC(void) PyThreadState_Delete(PyThreadState *);
#ifdef WITH_THREAD #ifdef WITH_THREAD

3
Misc/NEWS
View file

@ -12,6 +12,9 @@ What's New in Python 2.6.6 alpha 1?
Core and Builtins Core and Builtins
----------------- -----------------
- Issue #7544: Preallocate thread memory before creating the thread to avoid
a fatal error in low memory condition.
- Issue #7820: The parser tokenizer restores all bytes in the right if - Issue #7820: The parser tokenizer restores all bytes in the right if
the BOM check fails. the BOM check fails.

12
Modules/threadmodule.c
View file

@ -411,6 +411,7 @@ struct bootstate {
PyObject *func; PyObject *func;
PyObject *args; PyObject *args;
PyObject *keyw; PyObject *keyw;
PyThreadState *tstate;
}; };
static void static void
@ -420,8 +421,9 @@ t_bootstrap(void *boot_raw)
PyThreadState *tstate; PyThreadState *tstate;
PyObject *res; PyObject *res;
tstate = PyThreadState_New(boot->interp); tstate = boot->tstate;
tstate->thread_id = PyThread_get_thread_ident();
_PyThreadState_Init(tstate);
PyEval_AcquireThread(tstate); PyEval_AcquireThread(tstate);
res = PyEval_CallObjectWithKeywords( res = PyEval_CallObjectWithKeywords(
boot->func, boot->args, boot->keyw); boot->func, boot->args, boot->keyw);
@ -484,6 +486,11 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
boot->func = func; boot->func = func;
boot->args = args; boot->args = args;
boot->keyw = keyw; boot->keyw = keyw;
boot->tstate = _PyThreadState_Prealloc(boot->interp);
if (boot->tstate == NULL) {
PyMem_DEL(boot);
return PyErr_NoMemory();
}
Py_INCREF(func); Py_INCREF(func);
Py_INCREF(args); Py_INCREF(args);
Py_XINCREF(keyw); Py_XINCREF(keyw);
@ -494,6 +501,7 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
Py_DECREF(func); Py_DECREF(func);
Py_DECREF(args); Py_DECREF(args);
Py_XDECREF(keyw); Py_XDECREF(keyw);
PyThreadState_Clear(boot->tstate);
PyMem_DEL(boot); PyMem_DEL(boot);
return NULL; return NULL;
} }

28
Python/pystate.c
View file

@ -154,8 +154,8 @@ threadstate_getframe(PyThreadState *self)
return self->frame; return self->frame;
} }
PyThreadState * static PyThreadState *
PyThreadState_New(PyInterpreterState *interp) new_threadstate(PyInterpreterState *interp, int init)
{ {
PyThreadState *tstate = (PyThreadState *)malloc(sizeof(PyThreadState)); PyThreadState *tstate = (PyThreadState *)malloc(sizeof(PyThreadState));
@ -193,9 +193,8 @@ PyThreadState_New(PyInterpreterState *interp)
tstate->c_profileobj = NULL; tstate->c_profileobj = NULL;
tstate->c_traceobj = NULL; tstate->c_traceobj = NULL;
#ifdef WITH_THREAD if (init)
_PyGILState_NoteThreadState(tstate); _PyThreadState_Init(tstate);
#endif
HEAD_LOCK(); HEAD_LOCK();
tstate->next = interp->tstate_head; tstate->next = interp->tstate_head;
@ -206,6 +205,25 @@ PyThreadState_New(PyInterpreterState *interp)
return tstate; return tstate;
} }
PyThreadState *
PyThreadState_New(PyInterpreterState *interp)
{
return new_threadstate(interp, 1);
}
PyThreadState *
_PyThreadState_Prealloc(PyInterpreterState *interp)
{
return new_threadstate(interp, 0);
}
void
_PyThreadState_Init(PyThreadState *tstate)
{
#ifdef WITH_THREAD
_PyGILState_NoteThreadState(tstate);
#endif
}
void void
PyThreadState_Clear(PyThreadState *tstate) PyThreadState_Clear(PyThreadState *tstate)