mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-18 22:50:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

SF bug 486480: zipfile __del__ is broken

Browse source 
ZipFile.__del__():  call ZipFile.close(), like its docstring says it does.
ZipFile.close():  allow calling more than once (as all file-like objects
in Python should support).
This commit is contained in:
Tim Peters 2001-11-28 23:16:40 +00:00
parent 97019e4110
commit d15f8bbe32
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/zipfile.py
View file

@ -454,13 +454,13 @@ class ZipFile:
def __del__(self): def __del__(self):
"""Call the "close()" method in case the user forgot.""" """Call the "close()" method in case the user forgot."""
if self.fp and not self._filePassed: self.close()
self.fp.close()
self.fp = None
def close(self): def close(self):
"""Close the file, and for mode "w" and "a" write the ending """Close the file, and for mode "w" and "a" write the ending
records.""" records."""
if self.fp is None:
return
if self.mode in ("w", "a"): # write ending records if self.mode in ("w", "a"): # write ending records
count = 0 count = 0
pos1 = self.fp.tell() pos1 = self.fp.tell()