mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-29 03:35:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

[3.12] gh-111644: Fix asyncio test_unhandled_exceptions() (GH-111713) (#111718)

Browse source 
gh-111644: Fix asyncio test_unhandled_exceptions() (GH-111713)

Fix test_unhandled_exceptions() of test_asyncio.test_streams: break
explicitly a reference cycle.

Fix also StreamTests.tearDown(): the loop must not be closed
explicitly, but using set_event_loop() which takes care of shutting
down the executor with executor.shutdown(wait=True).
BaseEventLoop.close() calls executor.shutdown(wait=False).
(cherry picked from commit ac01e2243a)

Co-authored-by: Victor Stinner <vstinner@python.org>
This commit is contained in:
Miss Islington (bot) 2023-11-04 07:29:20 +01:00 • committed by GitHub
parent 02f8f781da
commit d15fac2a67
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/test/test_asyncio/test_streams.py
View file

@ -37,8 +37,7 @@ class StreamTests(test_utils.TestCase):
# just in case if we have transport close callbacks # just in case if we have transport close callbacks
test_utils.run_briefly(self.loop) test_utils.run_briefly(self.loop)
self.loop.close() # set_event_loop() takes care of closing self.loop in a safe way
gc.collect()
super().tearDown() super().tearDown()
def _basetest_open_connection(self, open_connection_fut): def _basetest_open_connection(self, open_connection_fut):
@ -1102,6 +1101,8 @@ os.close(fd)
self.assertEqual(messages[0]['message'], self.assertEqual(messages[0]['message'],
'Unhandled exception in client_connected_cb') 'Unhandled exception in client_connected_cb')
# Break explicitly reference cycle
messages = None
if __name__ == '__main__': if __name__ == '__main__':