mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-34334: Don't log traceback twice in QueueHandler (GH-9537)

Browse source
This commit is contained in:
Cheryl Sabella 2018-09-25 19:00:08 -04:00 • committed by Vinay Sajip
parent fad6af2744
commit d345bb4d9b
4 changed files with 23 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/test_logging.py
View file

@ -3345,6 +3345,21 @@ class QueueHandlerTest(BaseTest):
self.assertFalse(handler.matches(levelno=logging.WARNING, message='4'))
self.assertFalse(handler.matches(levelno=logging.ERROR, message='5'))
self.assertTrue(handler.matches(levelno=logging.CRITICAL, message='6'))
handler.close()
@unittest.skipUnless(hasattr(logging.handlers, 'QueueListener'),
'logging.handlers.QueueListener required for this test')
def test_queue_listener_with_StreamHandler(self):
# Test that traceback only appends once (bpo-34334).
listener = logging.handlers.QueueListener(self.queue, self.root_hdlr)
listener.start()
try:
1 / 0
except ZeroDivisionError as e:
exc = e
self.que_logger.exception(self.next_message(), exc_info=exc)
listener.stop()
self.assertEqual(self.stream.getvalue().strip().count('Traceback'), 1)
if hasattr(logging.handlers, 'QueueListener'):
import multiprocessing