mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 16:34:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

bpo-35182: fix communicate() crash after child closes its pipes (GH-17020) (GH-18117)

Browse source 
When communicate() is called in a loop, it crashes when the child process
has already closed any piped standard stream, but still continues to be running

Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>
This commit is contained in:
Alex Rebert 2020-01-22 18:28:31 -05:00 • committed by Gregory P. Smith
parent 1f0f102dec
commit d3ae95e1e9
3 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/subprocess.py
View file

@ -1983,9 +1983,9 @@ class Popen(object):
with _PopenSelector() as selector:
if self.stdin and input:
selector.register(self.stdin, selectors.EVENT_WRITE)
if self.stdout:
if self.stdout and not self.stdout.closed:
selector.register(self.stdout, selectors.EVENT_READ)
if self.stderr:
if self.stderr and not self.stderr.closed:
selector.register(self.stderr, selectors.EVENT_READ)
while selector.get_map():