mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-02 15:07:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Implement #1578269. Patch by Jason R. Coombs.

Browse source 
Added Windows support for os.symlink when run on Windows 6.0 or greater,
aka Vista. Previous Windows versions will raise NotImplementedError
when trying to symlink.

Includes numerous test updates and additions to test_os, including
a symlink_support module because of the fact that privilege escalation
is required in order to run the tests to ensure that the user is able
to create symlinks. By default, accounts do not have the required
privilege, so the escalation code will have to be exposed later (or
documented on how to do so). I'll be following up with that work next.

Note that the tests use ctypes, which was agreed on during the PyCon
language summit.
This commit is contained in:
Brian Curtin 2010-07-08 21:39:08 +00:00
parent 0dd8f7890a
commit d40e6f70a5
18 changed files with 1161 additions and 275 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Lib/test/support.py
View file

@ -17,6 +17,7 @@ import unittest
import importlib
import collections
import re
import subprocess
import imp
import time
try:
@ -38,8 +39,7 @@ __all__ = [
"set_memlimit", "bigmemtest", "bigaddrspacetest", "BasicTestRunner",
"run_unittest", "run_doctest", "threading_setup", "threading_cleanup",
"reap_children", "cpython_only", "check_impl_detail", "get_attribute",
"swap_item", "swap_attr",
]
"swap_item", "swap_attr", "can_symlink", "skip_unless_symlink"]
class Error(Exception):
@ -1169,6 +1169,27 @@ def reap_children():
except:
break
try:
from .symlink_support import enable_symlink_privilege
except:
enable_symlink_privilege = lambda: True
def can_symlink():
"""It's no longer sufficient to test for the presence of symlink in the
os module - on Windows XP and earlier, os.symlink exists but a
NotImplementedError is thrown.
"""
has_symlink = hasattr(os, 'symlink')
is_old_windows = sys.platform == "win32" and sys.getwindowsversion().major < 6
has_privilege = False if is_old_windows else enable_symlink_privilege()
return has_symlink and (not is_old_windows) and has_privilege
def skip_unless_symlink(test):
"""Skip decorator for tests that require functional symlink"""
selector = can_symlink()
msg = "Requires functional symlink implementation"
return [unittest.skip(msg)(test), test][selector]
@contextlib.contextmanager
def swap_attr(obj, attr, new_val):
"""Temporary swap out an attribute with a new object.