mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-02 11:08:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.

Browse source
This commit is contained in:
Serhiy Storchaka 2017-02-09 20:02:37 +02:00
parent e1857579f8
commit d43ab05916
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Modules/posixmodule.c
View file

@ -11865,7 +11865,6 @@ ScandirIterator_finalize(ScandirIterator *iterator)
} }
} }
Py_CLEAR(iterator->path.object);
path_cleanup(&iterator->path); path_cleanup(&iterator->path);
/* Restore the saved exception. */ /* Restore the saved exception. */
@ -11969,12 +11968,6 @@ posix_scandir(PyObject *self, PyObject *args, PyObject *kwargs)
path_converter, &iterator->path)) path_converter, &iterator->path))
goto error; goto error;
/* path_converter doesn't keep path.object around, so do it
manually for the lifetime of the iterator here (the refcount
is decremented in ScandirIterator_dealloc)
*/
Py_XINCREF(iterator->path.object);
#ifdef MS_WINDOWS #ifdef MS_WINDOWS
iterator->first_time = 1; iterator->first_time = 1;