gh-140939: Fix memory leak in _PyBytes_FormatEx error path (#140957)

This commit is contained in:
Stan Ulbrych 2025-11-06 05:50:57 +00:00 committed by GitHub
parent 9037a386c6
commit d6c89a2df2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 0 deletions

View file

@ -802,6 +802,13 @@ class BaseBytesTest:
with self.assertRaisesRegex(TypeError, msg):
operator.mod(format_bytes, value)
def test_memory_leak_gh_140939(self):
# gh-140939: MemoryError is raised without leaking
_testcapi = import_helper.import_module('_testcapi')
with self.assertRaises(MemoryError):
b = self.type2test(b'%*b')
b % (_testcapi.PY_SSIZE_T_MAX, b'abc')
def test_imod(self):
b = self.type2test(b'hello, %b!')
orig = b

View file

@ -0,0 +1,2 @@
Fix memory leak when :class:`bytearray` or :class:`bytes` is formated with the
``%*b`` format with a large width that results in a :exc:`MemoryError`.

View file

@ -985,6 +985,7 @@ _PyBytes_FormatEx(const char *format, Py_ssize_t format_len,
if (alloc > 2) {
res = PyBytesWriter_GrowAndUpdatePointer(writer, alloc - 2, res);
if (res == NULL) {
Py_XDECREF(temp);
goto error;
}
}