mirror of
https://github.com/python/cpython.git
synced 2025-08-03 16:39:00 +00:00
Issue #7282: Fix a memory leak when an RLock was used in a thread other
than those started through `threading.Thread` (for example, using `thread.start_new_thread()`.
This commit is contained in:
parent
d19915ed76
commit
d7158d4c62
4 changed files with 29 additions and 12 deletions
|
@ -130,6 +130,19 @@ class BaseLockTests(BaseTestCase):
|
|||
# Check the lock is unacquired
|
||||
Bunch(f, 1).wait_for_finished()
|
||||
|
||||
def test_thread_leak(self):
|
||||
# The lock shouldn't leak a Thread instance when used from a foreign
|
||||
# (non-threading) thread.
|
||||
lock = self.locktype()
|
||||
def f():
|
||||
lock.acquire()
|
||||
lock.release()
|
||||
n = len(threading.enumerate())
|
||||
# We run many threads in the hope that existing threads ids won't
|
||||
# be recycled.
|
||||
Bunch(f, 15).wait_for_finished()
|
||||
self.assertEqual(n, len(threading.enumerate()))
|
||||
|
||||
|
||||
class LockTests(BaseLockTests):
|
||||
"""
|
||||
|
|
|
@ -143,11 +143,9 @@ class ThreadTests(BaseTestCase):
|
|||
def test_foreign_thread(self):
|
||||
# Check that a "foreign" thread can use the threading module.
|
||||
def f(mutex):
|
||||
# Acquiring an RLock forces an entry for the foreign
|
||||
# Calling current_thread() forces an entry for the foreign
|
||||
# thread to get made in the threading._active map.
|
||||
r = threading.RLock()
|
||||
r.acquire()
|
||||
r.release()
|
||||
threading.current_thread()
|
||||
mutex.release()
|
||||
|
||||
mutex = threading.Lock()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue