mirror of
https://github.com/python/cpython.git
synced 2025-08-03 16:39:00 +00:00
bpo-18533: Avoid RecursionError from repr() of recursive dictview (#4823)
dictview_repr(): Use a Py_ReprEnter() / Py_ReprLeave() pair to check for recursion, and produce "..." if so. test_recursive_repr(): Check for the string rather than a RecursionError. (Test cannot be any tighter as contents are implementation-dependent.) test_deeply_nested_repr(): Add new test, replacing the original test_recursive_repr(). It checks that a RecursionError is raised in the case of a non-recursive but deeply nested structure. (Very similar to what test_repr_deep() in test/test_dict.py does for a normal dict.) OrderedDictTests: Add new test case, to test behavior on OrderedDict instances containing their own values() or items().
This commit is contained in:
parent
e76daebc0c
commit
d7773d92bd
4 changed files with 44 additions and 4 deletions
|
@ -1,6 +1,7 @@
|
|||
import collections.abc
|
||||
import copy
|
||||
import pickle
|
||||
import sys
|
||||
import unittest
|
||||
|
||||
class DictSetTest(unittest.TestCase):
|
||||
|
@ -202,6 +203,20 @@ class DictSetTest(unittest.TestCase):
|
|||
def test_recursive_repr(self):
|
||||
d = {}
|
||||
d[42] = d.values()
|
||||
r = repr(d)
|
||||
# Cannot perform a stronger test, as the contents of the repr
|
||||
# are implementation-dependent. All we can say is that we
|
||||
# want a str result, not an exception of any sort.
|
||||
self.assertIsInstance(r, str)
|
||||
d[42] = d.items()
|
||||
r = repr(d)
|
||||
# Again.
|
||||
self.assertIsInstance(r, str)
|
||||
|
||||
def test_deeply_nested_repr(self):
|
||||
d = {}
|
||||
for i in range(sys.getrecursionlimit() + 100):
|
||||
d = {42: d.values()}
|
||||
self.assertRaises(RecursionError, repr, d)
|
||||
|
||||
def test_copy(self):
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue