mirror of
https://github.com/python/cpython.git
synced 2025-07-12 13:55:34 +00:00
bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations (#51)
When you use `'%s' % SubClassOfStr()`, where `SubClassOfStr.__rmod__` exists, the reverse operation is ignored as normally such string formatting operations use the `PyUnicode_Format()` fast path. This patch tests for subclasses of `str` first and picks the slow path in that case. Patch by Martijn Pieters.
This commit is contained in:
parent
2771304357
commit
d7e64337ef
3 changed files with 22 additions and 3 deletions
|
@ -1448,6 +1448,15 @@ class UnicodeTest(string_tests.CommonTest,
|
|||
with self.assertRaises(ValueError):
|
||||
result = format_string % 2.34
|
||||
|
||||
def test_issue28598_strsubclass_rhs(self):
|
||||
# A subclass of str with an __rmod__ method should be able to hook
|
||||
# into the % operator
|
||||
class SubclassedStr(str):
|
||||
def __rmod__(self, other):
|
||||
return 'Success, self.__rmod__({!r}) was called'.format(other)
|
||||
self.assertEqual('lhs %% %r' % SubclassedStr('rhs'),
|
||||
"Success, self.__rmod__('lhs %% %r') was called")
|
||||
|
||||
@support.cpython_only
|
||||
def test_formatting_huge_precision_c_limits(self):
|
||||
from _testcapi import INT_MAX
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue