mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-03 16:19:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-46557: Log captured warnings without format string (GH-30975)

Browse source
This commit is contained in:
Michael P. Nitowski 2022-03-15 05:01:03 -04:00 • committed by GitHub
parent 16995ed0f2
commit d8066b420b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/logging/__init__.py
View file

@ -2246,7 +2246,9 @@ def _showwarning(message, category, filename, lineno, file=None, line=None):
logger = getLogger("py.warnings") logger = getLogger("py.warnings")
if not logger.handlers: if not logger.handlers:
logger.addHandler(NullHandler()) logger.addHandler(NullHandler())
logger.warning("%s", s) # bpo-46557: Log str(s) as msg instead of logger.warning("%s", s)
# since some log aggregation tools group logs by the msg arg
logger.warning(str(s))
def captureWarnings(capture): def captureWarnings(capture):
""" """

1
Misc/NEWS.d/next/Library/2022-01-28-01-23-25.bpo-46557.XSbhyQ.rst Normal file
View file

@ -0,0 +1 @@
Warnings captured by the logging module are now logged without a format string to prevent systems that group logs by the msg argument from grouping captured warnings together.