mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 02:39:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

bpo-43764: Fix __match_args__ generation logic for dataclasses (GH-25284)

Browse source
This commit is contained in:
Brandt Bucher 2021-04-08 12:54:34 -07:00 • committed by GitHub
parent 28d28e053d
commit d92c59f486
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/dataclasses.py
View file

@ -1017,7 +1017,7 @@ def _process_class(cls, init, repr, eq, order, unsafe_hash, frozen):
str(inspect.signature(cls)).replace(' -> NoneType', '')) str(inspect.signature(cls)).replace(' -> NoneType', ''))
if '__match_args__' not in cls.__dict__: if '__match_args__' not in cls.__dict__:
cls.__match_args__ = tuple(f.name for f in flds if f.init) cls.__match_args__ = tuple(f.name for f in field_list if f.init)
abc.update_abstractmethods(cls) abc.update_abstractmethods(cls)

8
Lib/test/test_dataclasses.py
View file

@ -3432,6 +3432,14 @@ class TestMatchArgs(unittest.TestCase):
__match_args__ = ma __match_args__ = ma
self.assertIs(C(42).__match_args__, ma) self.assertIs(C(42).__match_args__, ma)
def test_bpo_43764(self):
@dataclass(repr=False, eq=False, init=False)
class X:
a: int
b: int
c: int
self.assertEqual(X.__match_args__, ("a", "b", "c"))
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()

2
Misc/NEWS.d/next/Library/2021-04-08-09-59-20.bpo-43764.tHjO60.rst Normal file
View file

@ -0,0 +1,2 @@
Fix an issue where :data:`~object.__match_args__` generation could fail for
some :mod:`dataclasses`.