mirror of
https://github.com/python/cpython.git
synced 2025-08-03 16:39:00 +00:00
Improve an internal ipaddress test, add a comment explaining why treating networks as containers of interfaces rather than addresses would prove confusing
This commit is contained in:
parent
5b0dac12b8
commit
d972265df8
2 changed files with 31 additions and 17 deletions
|
@ -150,16 +150,31 @@ class IpaddrUnitTest(unittest.TestCase):
|
|||
self.assertEqual(first, last)
|
||||
self.assertEqual(0, ipaddress._get_prefix_length(2**32, 0, 32))
|
||||
self.assertEqual(128, ipaddress._count_righthand_zero_bits(0, 128))
|
||||
base_ip = ipaddress._BaseAddress('127.0.0.1')
|
||||
try:
|
||||
base_ip.version
|
||||
self.fail('_BaseAddress.version didn\'t raise NotImplementedError')
|
||||
except NotImplementedError:
|
||||
pass
|
||||
self.assertEqual("IPv4Network('1.2.3.0/24')", repr(self.ipv4_network))
|
||||
self.assertEqual('0x1020318', hex(self.ipv4_network))
|
||||
self.assertRaises(TypeError, self.ipv4_network.__eq__, object())
|
||||
|
||||
def testMissingAddressVersion(self):
|
||||
class Broken(ipaddress._BaseAddress):
|
||||
pass
|
||||
broken = Broken('127.0.0.1')
|
||||
with self.assertRaisesRegex(NotImplementedError, "Broken.*version"):
|
||||
broken.version
|
||||
|
||||
def testMissingNetworkVersion(self):
|
||||
class Broken(ipaddress._BaseNetwork):
|
||||
pass
|
||||
broken = Broken('127.0.0.1')
|
||||
with self.assertRaisesRegex(NotImplementedError, "Broken.*version"):
|
||||
broken.version
|
||||
|
||||
def testMissingAddressClass(self):
|
||||
class Broken(ipaddress._BaseNetwork):
|
||||
pass
|
||||
broken = Broken('127.0.0.1')
|
||||
with self.assertRaisesRegex(NotImplementedError, "Broken.*address"):
|
||||
broken._address_class
|
||||
|
||||
def testGetNetwork(self):
|
||||
self.assertEqual(int(self.ipv4_network.network_address), 16909056)
|
||||
self.assertEqual(str(self.ipv4_network.network_address), '1.2.3.0')
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue