mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #12607: In subprocess, fix issue where if stdin, stdout or stderr is

Browse source 
given as a low fd, it gets overwritten.
This commit is contained in:
Ross Lagerwall 2011-07-27 07:16:31 +02:00
parent 45686b472b
commit d98646e430
4 changed files with 76 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/subprocess.py
View file

@ -1219,6 +1219,14 @@ class Popen(object):
os.close(errread)
os.close(errpipe_read)
# When duping fds, if there arises a situation
# where one of the fds is either 0, 1 or 2, it
# is possible that it is overwritten (#12607).
if c2pwrite == 0:
c2pwrite = os.dup(c2pwrite)
if errwrite == 0 or errwrite == 1:
errwrite = os.dup(errwrite)
# Dup fds for child
def _dup2(a, b):
# dup2() removes the CLOEXEC flag but