mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-15 05:06:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Add some sanity checks to unittest.TestSuite's addTest(s) methods.

Browse source 
Fixes #878275.
This commit is contained in:
Georg Brandl 2007-03-07 11:54:49 +00:00
parent 9decc0dc8b
commit d9e50261e8
2 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/unittest.py
View file

@ -428,9 +428,18 @@ class TestSuite:
return cases
def addTest(self, test):
# sanity checks
if not callable(test):
raise TypeError("the test to add must be callable")
if (isinstance(test, (type, types.ClassType)) and
issubclass(test, (TestCase, TestSuite))):
raise TypeError("TestCases and TestSuites must be instantiated "
"before passing them to addTest()")
self._tests.append(test)
def addTests(self, tests):
if isinstance(tests, basestring):
raise TypeError("tests must be an iterable of tests, not a string")
for test in tests:
self.addTest(test)