mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-10 11:00:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

#6045: provide at least get() and setdefault() for all dbm modules.

Browse source
This commit is contained in:
Georg Brandl 2010-12-04 09:14:36 +00:00
parent da72231c9f
commit d9e833c70a
5 changed files with 63 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/dbm/dumb.py
View file

@ -203,7 +203,7 @@ class _Database(collections.MutableMapping):
# The blocks used by the associated value are lost.
del self._index[key]
# XXX It's unclear why we do a _commit() here (the code always
# XXX has, so I'm not changing it). _setitem__ doesn't try to
# XXX has, so I'm not changing it). __setitem__ doesn't try to
# XXX keep the directory file in synch. Why should we? Or
# XXX why shouldn't __setitem__?
self._commit()
@ -232,7 +232,7 @@ class _Database(collections.MutableMapping):
__del__ = close
def _chmod (self, file):
def _chmod(self, file):
if hasattr(self._os, 'chmod'):
self._os.chmod(file, self._mode)

4
Lib/test/test_dbm_gnu.py
View file

@ -32,6 +32,10 @@ class TestGdbm(unittest.TestCase):
key_set.remove(key)
key = self.g.nextkey(key)
self.assertRaises(KeyError, lambda: self.g['xxx'])
# get() and setdefault() work as in the dict interface
self.assertEqual(self.g.get(b'xxx', b'foo'), b'foo')
self.assertEqual(self.g.setdefault(b'xxx', b'foo'), b'foo')
self.assertEqual(self.g[b'xxx'], b'foo')
def test_error_conditions(self):
# Try to open a non-existent database.