mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-22 09:45:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (#97826)

Browse source 
* fix AttributeError, add unit test
This commit is contained in:
andrei kulakov 2022-10-04 20:47:49 -04:00 • committed by GitHub
parent 0ceafa7fa4
commit db64fb9bbe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/subprocess.py
View file

@ -456,7 +456,8 @@ def check_output(*popenargs, timeout=None, **kwargs):
if 'input' in kwargs and kwargs['input'] is None:
# Explicitly passing input=None was previously equivalent to passing an
# empty string. That is maintained here for backwards compatibility.
if kwargs.get('universal_newlines') or kwargs.get('text'):
if kwargs.get('universal_newlines') or kwargs.get('text') or kwargs.get('encoding') \
or kwargs.get('errors'):
empty = ''
else:
empty = b''