mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-02 16:13:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-71339: Use new assertion methods in test_idle (#129213)

Browse source 
Revise 10 tests in 7 files, with 1 test split into 2.
This commit is contained in:
Terry Jan Reedy 2025-01-23 13:25:14 -05:00 • committed by GitHub
parent c05a851ac5
commit dbb25ce037
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/idlelib/idle_test/test_configdialog.py
View file

@ -98,8 +98,8 @@ class ButtonTest(unittest.TestCase):
dialog.buttons['Help'].invoke()
title, contents = view.kwds['title'], view.kwds['contents']
self.assertEqual(title, 'Help for IDLE preferences')
self.assertTrue(contents.startswith('When you click') and
contents.endswith('a different name.\n'))
self.assertStartsWith(contents, 'When you click')
self.assertEndsWith(contents,'a different name.\n')
class FontPageTest(unittest.TestCase):

2
Lib/idlelib/idle_test/test_debugger.py
View file

@ -256,7 +256,7 @@ class StackViewerTest(unittest.TestCase):
flist = None
master_window = self.root
sv = debugger.StackViewer(master_window, flist, gui)
self.assertTrue(hasattr(sv, 'stack'))
self.assertHasAttr(sv, 'stack')
def test_load_stack(self):
# Test the .load_stack() method against a fixed test stack.

2
Lib/idlelib/idle_test/test_grep.py
View file

@ -143,7 +143,7 @@ class Grep_itTest(unittest.TestCase):
self.assertIn(pat, lines[0])
self.assertIn('py: 1:', lines[1]) # line number 1
self.assertIn('2', lines[3]) # hits found 2
self.assertTrue(lines[4].startswith('(Hint:'))
self.assertStartsWith(lines[4], '(Hint:')
class Default_commandTest(unittest.TestCase):

2
Lib/idlelib/idle_test/test_multicall.py
View file

@ -27,7 +27,7 @@ class MultiCallTest(unittest.TestCase):
def test_creator(self):
mc = self.mc
self.assertIs(multicall._multicall_dict[Text], mc)
self.assertTrue(issubclass(mc, Text))
self.assertIsSubclass(mc, Text)
mc2 = multicall.MultiCallCreator(Text)
self.assertIs(mc, mc2)

6
Lib/idlelib/idle_test/test_query.py
View file

@ -134,10 +134,10 @@ class ModuleNameTest(unittest.TestCase):
def test_good_module_name(self):
dialog = self.Dummy_ModuleName('idlelib')
self.assertTrue(dialog.entry_ok().endswith('__init__.py'))
self.assertEndsWith(dialog.entry_ok(), '__init__.py')
self.assertEqual(dialog.entry_error['text'], '')
dialog = self.Dummy_ModuleName('idlelib.idle')
self.assertTrue(dialog.entry_ok().endswith('idle.py'))
self.assertEndsWith(dialog.entry_ok(), 'idle.py')
self.assertEqual(dialog.entry_error['text'], '')
@ -389,7 +389,7 @@ class ModulenameGuiTest(unittest.TestCase):
self.assertEqual(dialog.text0, 'idlelib')
self.assertEqual(dialog.entry.get(), 'idlelib')
dialog.button_ok.invoke()
self.assertTrue(dialog.result.endswith('__init__.py'))
self.assertEndsWith(dialog.result, '__init__.py')
root.destroy()

2
Lib/idlelib/idle_test/test_redirector.py
View file

@ -34,7 +34,7 @@ class InitCloseTest(unittest.TestCase):
redir.register('insert', Func)
redir.close()
self.assertEqual(redir._operations, {})
self.assertFalse(hasattr(self.text, 'widget'))
self.assertNotHasAttr(self.text, 'widget')
class WidgetRedirectorTest(unittest.TestCase):

4
Lib/idlelib/idle_test/test_sidebar.py
View file

@ -725,7 +725,7 @@ class ShellSidebarTest(unittest.TestCase):
text.tag_add('sel', f'{first_line}.0', 'end-1c')
selected_text = text.get('sel.first', 'sel.last')
self.assertTrue(selected_text.startswith('if True:\n'))
self.assertStartsWith(selected_text, 'if True:\n')
self.assertIn('\n1\n', selected_text)
text.event_generate('<<copy>>')
@ -749,7 +749,7 @@ class ShellSidebarTest(unittest.TestCase):
text.tag_add('sel', f'{first_line}.3', 'end-1c')
selected_text = text.get('sel.first', 'sel.last')
self.assertTrue(selected_text.startswith('True:\n'))
self.assertStartsWith(selected_text, 'True:\n')
selected_lines_text = text.get('sel.first linestart', 'sel.last')
selected_lines = selected_lines_text.split('\n')