mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #12464: tempfile.TemporaryDirectory.cleanup() should not follow symlinks:

Browse source 
fix it. Patch by Petri Lehtinen.
This commit is contained in:
Charles-François Natali 2011-07-29 18:59:24 +02:00
parent fe1e298d8b
commit def35435ee
4 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Lib/test/test_tempfile.py
View file

@ -964,6 +964,27 @@ class test_TemporaryDirectory(TC):
finally:
os.rmdir(dir)
@support.skip_unless_symlink
def test_cleanup_with_symlink_to_a_directory(self):
# cleanup() should not follow symlinks to directories (issue #12464)
d1 = self.do_create()
d2 = self.do_create()
# Symlink d1/foo -> d2
os.symlink(d2.name, os.path.join(d1.name, "foo"))
# This call to cleanup() should not follow the "foo" symlink
d1.cleanup()
self.assertFalse(os.path.exists(d1.name),
"TemporaryDirectory %s exists after cleanup" % d1.name)
self.assertTrue(os.path.exists(d2.name),
"Directory pointed to by a symlink was deleted")
self.assertEqual(os.listdir(d2.name), ['test.txt'],
"Contents of the directory pointed to by a symlink "
"were deleted")
d2.cleanup()
@support.cpython_only
def test_del_on_collection(self):
# A TemporaryDirectory is deleted when garbage collected