mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Issue #4237: io.FileIO() was raising invalid warnings caused by insufficient initialization of PyFileIOObject struct members.

Browse source
This commit is contained in:
Christian Heimes 2008-10-30 21:23:35 +00:00
parent fec925b315
commit df32b3967c
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Lib/test/test_io.py
View file

@ -1237,6 +1237,13 @@ class MiscIOTest(unittest.TestCase):
else: else:
self.assert_(issubclass(obj, io.IOBase)) self.assert_(issubclass(obj, io.IOBase))
def test_fileio_warnings(self):
with support.check_warnings() as w:
self.assertEqual(w.warnings, [])
self.assertRaises(TypeError, io.FileIO, [])
self.assertEqual(w.warnings, [])
self.assertRaises(ValueError, io.FileIO, "/some/invalid/name", "rt")
self.assertEqual(w.warnings, [])
def test_main(): def test_main():
support.run_unittest(IOTest, BytesIOTest, StringIOTest, support.run_unittest(IOTest, BytesIOTest, StringIOTest,

6
Modules/_fileio.c
View file

@ -86,6 +86,10 @@ fileio_new(PyTypeObject *type, PyObject *args, PyObject *kews)
self = (PyFileIOObject *) type->tp_alloc(type, 0); self = (PyFileIOObject *) type->tp_alloc(type, 0);
if (self != NULL) { if (self != NULL) {
self->fd = -1; self->fd = -1;
self->readable = 0;
self->writable = 0;
self->seekable = -1;
self->closefd = 1;
self->weakreflist = NULL; self->weakreflist = NULL;
} }
@ -179,8 +183,6 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
} }
} }
self->readable = self->writable = 0;
self->seekable = -1;
s = mode; s = mode;
while (*s) { while (*s) {
switch (*s++) { switch (*s++) {