mirror of
https://github.com/python/cpython.git
synced 2025-07-24 19:54:21 +00:00
gh-111926: Make weakrefs thread-safe in free-threaded builds (#117168)
Most mutable data is protected by a striped lock that is keyed on the referenced object's address. The weakref's hash is protected using the weakref's per-object lock. Note that this only affects free-threaded builds. Apart from some minor refactoring, the added code is all either gated by `ifdef`s or is a no-op (e.g. `Py_BEGIN_CRITICAL_SECTION`).
This commit is contained in:
parent
e16062dd34
commit
df73179048
17 changed files with 490 additions and 326 deletions
|
@ -1907,6 +1907,25 @@ class MappingTestCase(TestBase):
|
|||
self.assertEqual(len(d), 1)
|
||||
o = None # lose ref
|
||||
|
||||
@support.cpython_only
|
||||
def test_weak_valued_consistency(self):
|
||||
# A single-threaded, deterministic repro for issue #28427: old keys
|
||||
# should not remove new values from WeakValueDictionary. This relies on
|
||||
# an implementation detail of CPython's WeakValueDictionary (its
|
||||
# underlying dictionary of KeyedRefs) to reproduce the issue.
|
||||
d = weakref.WeakValueDictionary()
|
||||
with support.disable_gc():
|
||||
d[10] = RefCycle()
|
||||
# Keep the KeyedRef alive after it's replaced so that GC will invoke
|
||||
# the callback.
|
||||
wr = d.data[10]
|
||||
# Replace the value with something that isn't cyclic garbage
|
||||
o = RefCycle()
|
||||
d[10] = o
|
||||
# Trigger GC, which will invoke the callback for `wr`
|
||||
gc.collect()
|
||||
self.assertEqual(len(d), 1)
|
||||
|
||||
def check_threaded_weak_dict_copy(self, type_, deepcopy):
|
||||
# `type_` should be either WeakKeyDictionary or WeakValueDictionary.
|
||||
# `deepcopy` should be either True or False.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue