mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-23 18:24:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-35379: When exiting IDLE, catch any AttributeError. (GH-16212)

Browse source 
One happens when EditorWindow.close is called twice.
Printing a traceback, when IDLE is run from a terminal,
is useless and annoying.
This commit is contained in:
Terry Jan Reedy 2019-09-17 02:05:04 -04:00 • committed by GitHub
parent 63dedef48b
commit dfd34a9cd5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Lib/idlelib/NEWS.txt
View file

@ -2,6 +2,13 @@ What's New in IDLE 3.8.0 (since 3.7.0)
Released on 2019-10-20? Released on 2019-10-20?
====================================== ======================================
bpo-35379: When exiting IDLE, catch any AttributeError. One happens
when EditorWindow.close is called twice. Printing a traceback, when
IDLE is run from a terminal, is useless and annoying.
bpo-38183: To avoid test issues, test_idle ignores the user config
directory. It no longer tries to create or access .idlerc or any files
within. Users must run IDLE to discover problems with saving settings.
bpo-38077: IDLE no longer adds 'argv' to the user namespace when bpo-38077: IDLE no longer adds 'argv' to the user namespace when
initializing it. This bug only affected 3.7.4 and 3.8.0b2 to 3.8.0b4. initializing it. This bug only affected 3.7.4 and 3.8.0b2 to 3.8.0b4.

3
Lib/idlelib/editor.py
View file

@ -1061,10 +1061,13 @@ class EditorWindow(object):
return self.io.maybesave() return self.io.maybesave()
def close(self): def close(self):
try:
reply = self.maybesave() reply = self.maybesave()
if str(reply) != "cancel": if str(reply) != "cancel":
self._close() self._close()
return reply return reply
except AttributeError: # bpo-35379: close called twice
pass
def _close(self): def _close(self):
if self.io.filename: if self.io.filename:

3
Misc/NEWS.d/next/IDLE/2019-09-17-01-28-56.bpo-35379.yAECDr.rst Normal file
View file

@ -0,0 +1,3 @@
When exiting IDLE, catch any AttributeError. One happens when
EditorWindow.close is called twice. Printing a traceback, when IDLE is run
from a terminal, is useless and annoying.