gh-138250: load fast optimization should fall through to empty blocks (#138249)
Some checks are pending
Tests / Change detection (push) Waiting to run
Tests / Docs (push) Blocked by required conditions
Tests / Check if Autoconf files are up to date (push) Blocked by required conditions
Tests / Check if generated files are up to date (push) Blocked by required conditions
Tests / (push) Blocked by required conditions
Tests / Windows MSI (push) Blocked by required conditions
Tests / Ubuntu SSL tests with OpenSSL (push) Blocked by required conditions
Tests / Ubuntu SSL tests with AWS-LC (push) Blocked by required conditions
Tests / Android (aarch64) (push) Blocked by required conditions
Tests / Android (x86_64) (push) Blocked by required conditions
Tests / WASI (push) Blocked by required conditions
Tests / Hypothesis tests on Ubuntu (push) Blocked by required conditions
Tests / Address sanitizer (push) Blocked by required conditions
Tests / Sanitizers (push) Blocked by required conditions
Tests / Cross build Linux (push) Blocked by required conditions
Tests / CIFuzz (push) Blocked by required conditions
Tests / All required checks pass (push) Blocked by required conditions
Lint / lint (push) Waiting to run
mypy / Run mypy on Lib/_pyrepl (push) Waiting to run
mypy / Run mypy on Lib/test/libregrtest (push) Waiting to run
mypy / Run mypy on Lib/tomllib (push) Waiting to run
mypy / Run mypy on Tools/build (push) Waiting to run
mypy / Run mypy on Tools/cases_generator (push) Waiting to run
mypy / Run mypy on Tools/clinic (push) Waiting to run
mypy / Run mypy on Tools/jit (push) Waiting to run
mypy / Run mypy on Tools/peg_generator (push) Waiting to run

load fast optimization should fall through to empty blocks
This commit is contained in:
Dino Viehland 2025-08-29 11:49:35 -07:00 committed by GitHub
parent 5f7906715a
commit e05182f98e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -2993,11 +2993,8 @@ optimize_load_fast(cfg_builder *g)
}
// Push fallthrough block
cfg_instr *term = basicblock_last_instr(block);
if (term != NULL && block->b_next != NULL &&
!(IS_UNCONDITIONAL_JUMP_OPCODE(term->i_opcode) ||
IS_SCOPE_EXIT_OPCODE(term->i_opcode))) {
assert(BB_HAS_FALLTHROUGH(block));
if (BB_HAS_FALLTHROUGH(block)) {
assert(block->b_next != NULL);
load_fast_push_block(&sp, block->b_next, refs.size);
}