Fix two crashers (borrowed_ref_[34].py from the trunk).

This commit is contained in:
Guido van Rossum 2008-01-23 20:09:39 +00:00
parent 2529aa9840
commit e105f98046
2 changed files with 11 additions and 2 deletions

View file

@ -1218,11 +1218,14 @@ min_max(PyObject *args, PyObject *kwds, int op)
"%s() got an unexpected keyword argument", name); "%s() got an unexpected keyword argument", name);
return NULL; return NULL;
} }
Py_INCREF(keyfunc);
} }
it = PyObject_GetIter(v); it = PyObject_GetIter(v);
if (it == NULL) if (it == NULL) {
Py_XDECREF(keyfunc);
return NULL; return NULL;
}
maxitem = NULL; /* the result */ maxitem = NULL; /* the result */
maxval = NULL; /* the value associated with the result */ maxval = NULL; /* the value associated with the result */
@ -1271,6 +1274,7 @@ min_max(PyObject *args, PyObject *kwds, int op)
else else
Py_DECREF(maxval); Py_DECREF(maxval);
Py_DECREF(it); Py_DECREF(it);
Py_XDECREF(keyfunc);
return maxitem; return maxitem;
Fail_it_item_and_val: Fail_it_item_and_val:
@ -1281,6 +1285,7 @@ Fail_it:
Py_XDECREF(maxval); Py_XDECREF(maxval);
Py_XDECREF(maxitem); Py_XDECREF(maxitem);
Py_DECREF(it); Py_DECREF(it);
Py_XDECREF(keyfunc);
return NULL; return NULL;
} }

View file

@ -2036,6 +2036,7 @@ PyEval_EvalFrameEx(PyFrameObject *f, int throwflag)
"__import__ not found"); "__import__ not found");
break; break;
} }
Py_INCREF(x);
v = POP(); v = POP();
u = TOP(); u = TOP();
if (PyInt_AsLong(u) != -1 || PyErr_Occurred()) if (PyInt_AsLong(u) != -1 || PyErr_Occurred())
@ -2057,11 +2058,14 @@ PyEval_EvalFrameEx(PyFrameObject *f, int throwflag)
Py_DECREF(u); Py_DECREF(u);
if (w == NULL) { if (w == NULL) {
u = POP(); u = POP();
Py_DECREF(x);
x = NULL; x = NULL;
break; break;
} }
READ_TIMESTAMP(intr0); READ_TIMESTAMP(intr0);
x = PyEval_CallObject(x, w); v = x;
x = PyEval_CallObject(v, w);
Py_DECREF(v);
READ_TIMESTAMP(intr1); READ_TIMESTAMP(intr1);
Py_DECREF(w); Py_DECREF(w);
SET_TOP(x); SET_TOP(x);