mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 08:31:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

bpo-34149: Behavior of the min/max with key=None (GH-8328)

Browse source 
Improve consistency with the signature for sorted(), heapq.nsmallest(), heapq.nlargest(), and itertools.groupby().
This commit is contained in:
Alexander Marshalov 2018-07-24 10:58:21 +07:00 • committed by Raymond Hettinger
parent bde782bb59
commit e22072fb11
5 changed files with 17 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/test_builtin.py
View file

@ -905,6 +905,8 @@ class BuiltinTest(unittest.TestCase):
self.assertEqual(max((), default=1, key=neg), 1)
self.assertEqual(max((1, 2), default=3, key=neg), 1)
self.assertEqual(max((1, 2), key=None), 2)
data = [random.randrange(200) for i in range(100)]
keys = dict((elem, random.randrange(50)) for elem in data)
f = keys.__getitem__
@ -957,6 +959,8 @@ class BuiltinTest(unittest.TestCase):
self.assertEqual(min((), default=1, key=neg), 1)
self.assertEqual(min((1, 2), default=1, key=neg), 2)
self.assertEqual(min((1, 2), key=None), 1)
data = [random.randrange(200) for i in range(100)]
keys = dict((elem, random.randrange(50)) for elem in data)
f = keys.__getitem__