mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-22 17:55:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

gh-76763: Make chr() always raising ValueError for out-of-range values (GH-114882)

Browse source 
Previously it raised OverflowError for very large or very small values.
This commit is contained in:
Serhiy Storchaka 2024-02-10 12:21:35 +02:00 • committed by GitHub
parent 6e222a55b1
commit e2c4038924
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 32 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Python/bltinmodule.c
View file

@ -703,17 +703,34 @@ builtin_format_impl(PyObject *module, PyObject *value, PyObject *format_spec)
/*[clinic input]
chr as builtin_chr
i: int
i: object
/
Return a Unicode string of one character with ordinal i; 0 <= i <= 0x10ffff.
[clinic start generated code]*/
static PyObject *
builtin_chr_impl(PyObject *module, int i)
/*[clinic end generated code: output=c733afcd200afcb7 input=3f604ef45a70750d]*/
builtin_chr(PyObject *module, PyObject *i)
/*[clinic end generated code: output=d34f25b8035a9b10 input=f919867f0ba2f496]*/
{
return PyUnicode_FromOrdinal(i);
int overflow;
long v = PyLong_AsLongAndOverflow(i, &overflow);
if (v == -1 && PyErr_Occurred()) {
return NULL;
}
if (overflow) {
v = overflow < 0 ? INT_MIN : INT_MAX;
/* Allow PyUnicode_FromOrdinal() to raise an exception */
}
#if SIZEOF_INT < SIZEOF_LONG
else if (v < INT_MIN) {
v = INT_MIN;
}
else if (v > INT_MAX) {
v = INT_MAX;
}
#endif
return PyUnicode_FromOrdinal(v);
}