mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-15 21:44:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Issue #23728: binascii.crc_hqx() could return an integer outside of the range

Browse source 
0-0xffff for empty data.
This commit is contained in:
Serhiy Storchaka 2015-04-20 09:31:51 +03:00
commit e3037e1145
4 changed files with 31 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Modules/clinic/binascii.c.h
View file

@ -267,25 +267,25 @@ PyDoc_STRVAR(binascii_crc_hqx__doc__,
#define BINASCII_CRC_HQX_METHODDEF \
{"crc_hqx", (PyCFunction)binascii_crc_hqx, METH_VARARGS, binascii_crc_hqx__doc__},
static int
binascii_crc_hqx_impl(PyModuleDef *module, Py_buffer *data, int crc);
static unsigned int
binascii_crc_hqx_impl(PyModuleDef *module, Py_buffer *data, unsigned int crc);
static PyObject *
binascii_crc_hqx(PyModuleDef *module, PyObject *args)
{
PyObject *return_value = NULL;
Py_buffer data = {NULL, NULL};
int crc;
int _return_value;
unsigned int crc;
unsigned int _return_value;
if (!PyArg_ParseTuple(args,
"y*i:crc_hqx",
"y*I:crc_hqx",
&data, &crc))
goto exit;
_return_value = binascii_crc_hqx_impl(module, &data, crc);
if ((_return_value == -1) && PyErr_Occurred())
if ((_return_value == (unsigned int)-1) && PyErr_Occurred())
goto exit;
return_value = PyLong_FromLong((long)_return_value);
return_value = PyLong_FromUnsignedLong((unsigned long)_return_value);
exit:
/* Cleanup for data */
@ -544,4 +544,4 @@ exit:
return return_value;
}
/*[clinic end generated code: output=175025a8a94fbdd1 input=a9049054013a1b77]*/
/*[clinic end generated code: output=5f8d3578618b3432 input=a9049054013a1b77]*/