mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 02:10:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-107838: In dataclasses, improve error message when a non-default field follows a default field. (gh-107842)

Browse source 
Add the name of the previous default argument field in an error message.
This commit is contained in:
Eric V. Smith 2023-08-10 09:39:13 -05:00 • committed by GitHub
parent 37d8b904f8
commit e4275f4df3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_dataclasses.py
View file

@ -134,7 +134,7 @@ class TestCase(unittest.TestCase):
# Non-defaults following defaults.
with self.assertRaisesRegex(TypeError,
"non-default argument 'y' follows "
"default argument"):
"default argument 'x'"):
@dataclass
class C:
x: int = 0
@ -143,7 +143,7 @@ class TestCase(unittest.TestCase):
# A derived class adds a non-default field after a default one.
with self.assertRaisesRegex(TypeError,
"non-default argument 'y' follows "
"default argument"):
"default argument 'x'"):
@dataclass
class B:
x: int = 0
@ -156,7 +156,7 @@ class TestCase(unittest.TestCase):
# a field which didn't use to have a default.
with self.assertRaisesRegex(TypeError,
"non-default argument 'y' follows "
"default argument"):
"default argument 'x'"):
@dataclass
class B:
x: int
@ -4521,7 +4521,7 @@ class TestKeywordArgs(unittest.TestCase):
# Make sure we still check for non-kwarg non-defaults not following
# defaults.
err_regex = "non-default argument 'z' follows default argument"
err_regex = "non-default argument 'z' follows default argument 'a'"
with self.assertRaisesRegex(TypeError, err_regex):
@dataclass
class A: