mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Issue #29094: Offsets in a ZIP file created with extern file object and modes

Browse source 
"w" and "x" now are relative to the start of the file.
This commit is contained in:
Serhiy Storchaka 2017-01-01 19:05:29 +02:00
commit e465a9af8e
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/zipfile.py
View file

@ -1102,11 +1102,12 @@ class ZipFile:
# set the modified flag so central directory gets written # set the modified flag so central directory gets written
# even if no files are added to the archive # even if no files are added to the archive
self._didModify = True self._didModify = True
self._start_disk = 0
try: try:
self.start_dir = self._start_disk = self.fp.tell() self.start_dir = self.fp.tell()
except (AttributeError, OSError): except (AttributeError, OSError):
self.fp = _Tellable(self.fp) self.fp = _Tellable(self.fp)
self.start_dir = self._start_disk = 0 self.start_dir = 0
self._seekable = False self._seekable = False
else: else:
# Some file-like objects can provide tell() but not seek() # Some file-like objects can provide tell() but not seek()

3
Misc/NEWS
View file

@ -40,6 +40,9 @@ Core and Builtins
Library Library
------- -------
- Issue #29094: Offsets in a ZIP file created with extern file object and modes
"w" and "x" now are relative to the start of the file.
- Issue #29085: Allow random.Random.seed() to use high quality OS randomness - Issue #29085: Allow random.Random.seed() to use high quality OS randomness
rather than the pid and time. rather than the pid and time.