mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-17 20:28:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Issue #16230: Fix a crash in select.select() when one the lists changes size while iterated on.

Browse source 
Patch by Serhiy Storchaka.
This commit is contained in:
Antoine Pitrou 2012-11-01 20:13:54 +01:00
parent 9f69e79c45
commit e4ad37e50e
3 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Modules/selectmodule.c
View file

@ -83,7 +83,7 @@ seq2set(PyObject *seq, fd_set *set, pylist fd2obj[FD_SETSIZE + 1])
{
int max = -1;
int index = 0;
Py_ssize_t i, len = -1;
Py_ssize_t i;
PyObject* fast_seq = NULL;
PyObject* o = NULL;
@ -94,9 +94,7 @@ seq2set(PyObject *seq, fd_set *set, pylist fd2obj[FD_SETSIZE + 1])
if (!fast_seq)
return -1;
len = PySequence_Fast_GET_SIZE(fast_seq);
for (i = 0; i < len; i++) {
for (i = 0; i < PySequence_Fast_GET_SIZE(fast_seq); i++) {
SOCKET v;
/* any intervening fileno() calls could decr this refcnt */