mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-01 10:45:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

(Merge 3.4) Issue #12523: asynchat.async_chat.push() now raises a TypeError if

Browse source 
it doesn't get a bytes string
This commit is contained in:
Victor Stinner 2014-07-08 00:01:28 +02:00
commit e8209dab6b
3 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Lib/test/test_asynchat.py
View file

@ -250,6 +250,22 @@ class TestAsynchat(unittest.TestCase):
# (which could still result in the client not having received anything)
self.assertGreater(len(s.buffer), 0)
def test_push(self):
# Issue #12523: push() should raise a TypeError if it doesn't get
# a bytes string
s, event = start_echo_server()
c = echo_client(b'\n', s.port)
data = b'bytes\n'
c.push(data)
c.push(bytearray(data))
c.push(memoryview(data))
self.assertRaises(TypeError, c.push, 10)
self.assertRaises(TypeError, c.push, 'unicode')
c.push(SERVER_QUIT)
asyncore.loop(use_poll=self.usepoll, count=300, timeout=.01)
s.join(timeout=TIMEOUT)
self.assertEqual(c.contents, [b'bytes', b'bytes', b'bytes'])
class TestAsynchat_WithPoll(TestAsynchat):
usepoll = True