mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 21:48:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Issue #1731717: Fixed the problem where subprocess.wait() could cause an

Browse source 
OSError exception when The OS had been told to ignore SIGCLD in our process
or otherwise not wait for exiting child processes.
This commit is contained in:
Gregory P. Smith 2010-12-14 14:38:00 +00:00
parent 32ef70c827
commit e85db2bbb8
4 changed files with 34 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Lib/subprocess.py
View file

@ -1295,7 +1295,11 @@ class Popen(object):
os.close(errpipe_read)
if data:
_eintr_retry_call(os.waitpid, self.pid, 0)
try:
_eintr_retry_call(os.waitpid, self.pid, 0)
except OSError as e:
if e.errno != errno.ECHILD:
raise
try:
exception_name, hex_errno, err_msg = data.split(b':', 2)
except ValueError:
@ -1358,7 +1362,15 @@ class Popen(object):
"""Wait for child process to terminate. Returns returncode
attribute."""
if self.returncode is None:
pid, sts = _eintr_retry_call(os.waitpid, self.pid, 0)
try:
pid, sts = _eintr_retry_call(os.waitpid, self.pid, 0)
except OSError as e:
if e.errno != errno.ECHILD:
raise
# This happens if SIGCLD is set to be ignored or waiting
# for child processes has otherwise been disabled for our
# process. This child is dead, we can't get the status.
sts = 0
self._handle_exitstatus(sts)
return self.returncode