mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 11:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #18876: The FileIO.mode attribute now better reflects the actual mode under which the file was opened.

Browse source 
Patch by Erik Bray.
This commit is contained in:
Antoine Pitrou 2013-09-04 20:46:33 +02:00
parent c9e1dcdd53
commit e93b63b74b
3 changed files with 32 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Lib/test/test_fileio.py
View file

@ -304,7 +304,7 @@ class OtherFileTests(unittest.TestCase):
finally:
os.unlink(TESTFN)
def testModeStrings(self):
def testInvalidModeStrings(self):
# check invalid mode strings
for mode in ("", "aU", "wU+", "rw", "rt"):
try:
@ -315,6 +315,21 @@ class OtherFileTests(unittest.TestCase):
f.close()
self.fail('%r is an invalid file mode' % mode)
def testModeStrings(self):
# test that the mode attribute is correct for various mode strings
# given as init args
try:
for modes in [('w', 'wb'), ('wb', 'wb'), ('wb+', 'rb+'),
('w+b', 'rb+'), ('a', 'ab'), ('ab', 'ab'),
('ab+', 'ab+'), ('a+b', 'ab+'), ('r', 'rb'),
('rb', 'rb'), ('rb+', 'rb+'), ('r+b', 'rb+')]:
# read modes are last so that TESTFN will exist first
with _FileIO(TESTFN, modes[0]) as f:
self.assertEqual(f.mode, modes[1])
finally:
if os.path.exists(TESTFN):
os.unlink(TESTFN)
def testUnicodeOpen(self):
# verify repr works for unicode too
f = _FileIO(str(TESTFN), "w")