mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

gh-65865: Raise early errors for invalid help strings in argparse (GH-124899)

Browse source
This commit is contained in:
Serhiy Storchaka 2024-10-12 13:10:50 +03:00 • committed by GitHub
parent 4a943c3251
commit eb2d268ac7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 58 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Lib/test/test_argparse.py
View file

@ -2623,6 +2623,29 @@ class TestAddSubparsers(TestCase):
--foo foo help
'''))
def assert_bad_help(self, context_type, func, *args, **kwargs):
with self.assertRaisesRegex(ValueError, 'badly formed help string') as cm:
func(*args, **kwargs)
self.assertIsInstance(cm.exception.__context__, context_type)
def test_invalid_subparsers_help(self):
parser = ErrorRaisingArgumentParser(prog='PROG')
self.assert_bad_help(ValueError, parser.add_subparsers, help='%Y-%m-%d')
parser = ErrorRaisingArgumentParser(prog='PROG')
self.assert_bad_help(KeyError, parser.add_subparsers, help='%(spam)s')
parser = ErrorRaisingArgumentParser(prog='PROG')
self.assert_bad_help(TypeError, parser.add_subparsers, help='%(prog)d')
def test_invalid_subparser_help(self):
parser = ErrorRaisingArgumentParser(prog='PROG')
subparsers = parser.add_subparsers()
self.assert_bad_help(ValueError, subparsers.add_parser, '1',
help='%Y-%m-%d')
self.assert_bad_help(KeyError, subparsers.add_parser, '1',
help='%(spam)s')
self.assert_bad_help(TypeError, subparsers.add_parser, '1',
help='%(prog)d')
def test_subparser_title_help(self):
parser = ErrorRaisingArgumentParser(prog='PROG',
description='main description')
@ -5375,6 +5398,14 @@ class TestInvalidArgumentConstructors(TestCase):
self.assertValueError('--foo', action="store-true",
errmsg='unknown action')
def test_invalid_help(self):
self.assertValueError('--foo', help='%Y-%m-%d',
errmsg='badly formed help string')
self.assertValueError('--foo', help='%(spam)s',
errmsg='badly formed help string')
self.assertValueError('--foo', help='%(prog)d',
errmsg='badly formed help string')
def test_multiple_dest(self):
parser = argparse.ArgumentParser()
parser.add_argument(dest='foo')