mirror of
https://github.com/python/cpython.git
synced 2025-08-01 15:43:13 +00:00
Issue #2776: fixed small issue when handling an URL with double slash
after a 302 response in the case of not going through a proxy.
This commit is contained in:
parent
5b02ef3e1b
commit
eb90b788f4
3 changed files with 38 additions and 3 deletions
|
@ -772,6 +772,32 @@ class HandlerTests(unittest.TestCase):
|
|||
self.assertEqual(req.unredirected_hdrs["Host"], "baz")
|
||||
self.assertEqual(req.unredirected_hdrs["Spam"], "foo")
|
||||
|
||||
def test_http_doubleslash(self):
|
||||
# Checks that the presence of an unnecessary double slash in a url doesn't break anything
|
||||
# Previously, a double slash directly after the host could cause incorrect parsing of the url
|
||||
h = urllib2.AbstractHTTPHandler()
|
||||
o = h.parent = MockOpener()
|
||||
|
||||
data = ""
|
||||
ds_urls = [
|
||||
"http://example.com/foo/bar/baz.html",
|
||||
"http://example.com//foo/bar/baz.html",
|
||||
"http://example.com/foo//bar/baz.html",
|
||||
"http://example.com/foo/bar//baz.html",
|
||||
]
|
||||
|
||||
for ds_url in ds_urls:
|
||||
ds_req = Request(ds_url, data)
|
||||
|
||||
# Check whether host is determined correctly if there is no proxy
|
||||
np_ds_req = h.do_request_(ds_req)
|
||||
self.assertEqual(np_ds_req.unredirected_hdrs["Host"],"example.com")
|
||||
|
||||
# Check whether host is determined correctly if there is a proxy
|
||||
ds_req.set_proxy("someproxy:3128",None)
|
||||
p_ds_req = h.do_request_(ds_req)
|
||||
self.assertEqual(p_ds_req.unredirected_hdrs["Host"],"example.com")
|
||||
|
||||
def test_errors(self):
|
||||
h = urllib2.HTTPErrorProcessor()
|
||||
o = h.parent = MockOpener()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue