mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-15 21:26:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

gh-131884: Fix incorrect formatting in json.dumps() when using indent and skipkeys=True (GH-132200)

Browse source
This commit is contained in:
Roei Ben Artzi 2025-06-03 10:40:25 +03:00 • committed by GitHub
parent 485b499610
commit ec12559eba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Modules/_json.c
View file

@ -1603,6 +1603,12 @@ encoder_encode_key_value(PyEncoderObject *s, PyUnicodeWriter *writer, bool *firs
if (*first) {
*first = false;
if (s->indent != Py_None) {
if (write_newline_indent(writer, indent_level, indent_cache) < 0) {
Py_DECREF(keystr);
return -1;
}
}
}
else {
if (PyUnicodeWriter_WriteStr(writer, item_separator) < 0) {
@ -1670,11 +1676,8 @@ encoder_listencode_dict(PyEncoderObject *s, PyUnicodeWriter *writer,
if (s->indent != Py_None) {
indent_level++;
separator = get_item_separator(s, indent_level, indent_cache);
if (separator == NULL ||
write_newline_indent(writer, indent_level, indent_cache) < 0)
{
if (separator == NULL)
goto bail;
}
}
if (s->sort_keys || !PyDict_CheckExact(dct)) {
@ -1714,7 +1717,7 @@ encoder_listencode_dict(PyEncoderObject *s, PyUnicodeWriter *writer,
goto bail;
Py_CLEAR(ident);
}
if (s->indent != Py_None) {
if (s->indent != Py_None && !first) {
indent_level--;
if (write_newline_indent(writer, indent_level, indent_cache) < 0) {
goto bail;