mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 11:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #22995: [UPDATE] Comment out the one of the pickleability tests in

Browse source 
_PyObject_GetState() due to regressions observed in Cython-based projects.
This commit is contained in:
Barry Warsaw 2016-01-11 13:49:40 -05:00
commit ec71f1779f
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Objects/typeobject.c
View file

@ -3872,6 +3872,14 @@ _PyObject_GetState(PyObject *obj, int required)
}
assert(slotnames == Py_None || PyList_Check(slotnames));
#if 0
/* 2016-01-11 barry - This clause breaks at least three packages which
rely on Cython: kivy, pysam, and s3ql. Cython may be doing
something funny under the hood, but as this is clearly a regression
and the rationale for this prohibition is suspect, I am commenting
this out. Perhaps it should just be removed. See issue #22995 for
details.
*/
if (required) {
Py_ssize_t basicsize = PyBaseObject_Type.tp_basicsize;
if (obj->ob_type->tp_dictoffset)
@ -3889,6 +3897,7 @@ _PyObject_GetState(PyObject *obj, int required)
return NULL;
}
}
#endif
if (slotnames != Py_None && Py_SIZE(slotnames) > 0) {
PyObject *slots;