mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

gh-117267: Ensure DirEntry.stat().st_ctime still contains creation time during deprecation period (GH-117354)

Browse source 
(cherry picked from commit 985917dc8d)

Co-authored-by: Steve Dower <steve.dower@python.org>
This commit is contained in:
Miss Islington (bot) 2024-04-04 00:32:09 +02:00 • committed by GitHub
parent fad48ea181
commit eca377f203
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst Normal file
View file

@ -0,0 +1,5 @@
Ensure ``DirEntry.stat().st_ctime`` behaves consistently with
:func:`os.stat` during the deprecation period of ``st_ctime`` by containing
the same value as ``st_birthtime``. After the deprecation period,
``st_ctime`` will be the metadata change time (or unavailable through
``DirEntry``), and only ``st_birthtime`` will contain the creation time.

4
Modules/posixmodule.c
View file

@ -15050,6 +15050,10 @@ DirEntry_from_find_data(PyObject *module, path_t *path, WIN32_FIND_DATAW *dataW)
find_data_to_file_info(dataW, &file_info, &reparse_tag); find_data_to_file_info(dataW, &file_info, &reparse_tag);
_Py_attribute_data_to_stat(&file_info, reparse_tag, NULL, NULL, &entry->win32_lstat); _Py_attribute_data_to_stat(&file_info, reparse_tag, NULL, NULL, &entry->win32_lstat);
/* ctime is only deprecated from 3.12, so we copy birthtime across */
entry->win32_lstat.st_ctime = entry->win32_lstat.st_birthtime;
entry->win32_lstat.st_ctime_nsec = entry->win32_lstat.st_birthtime_nsec;
return (PyObject *)entry; return (PyObject *)entry;
error: error: