mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 13:38:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Document the demise of all pretenses of safety, and the difference

Browse source 
between cPickle and pickle.py regarding __safe_for_unpickling__ before
Python 2.3.
This commit is contained in:
Guido van Rossum 2003-01-29 06:24:30 +00:00
parent 586c9e813c
commit ecb1104342
1 changed files with 17 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Lib/pickletools.py
View file

@ -125,6 +125,17 @@ The third major set of additions came in Python 2.3, and is called "protocol
efficiently by index (EXT{1,2,4}). This is akin to the memo and GET, but efficiently by index (EXT{1,2,4}). This is akin to the memo and GET, but
the registry contents are predefined (there's nothing akin to the memo's the registry contents are predefined (there's nothing akin to the memo's
PUT). PUT).
Another, independent change with Python 2.3 is the abandonment of any
pretense that it might be safe to pickles received from untrusted
parties -- no sufficient security analysis has been done to guarantee
this and there isn't a use case to warrants the expense of such an
analysis.
To this end, all tests for __safe_for_unpickling__ or for
copy_reg.safe_constructors are removed from the unpickling code.
References to these variables in the descriptions below are to be seen
as describing unpickling in Python 2.2 and before.
""" """
# Meta-rule: Descriptions are stored in instances of descriptor objects, # Meta-rule: Descriptions are stored in instances of descriptor objects,
@ -1591,8 +1602,9 @@ opcodes = [
first insists that the class object have a __safe_for_unpickling__ first insists that the class object have a __safe_for_unpickling__
attribute. Unlike as for the __safe_for_unpickling__ check in REDUCE, attribute. Unlike as for the __safe_for_unpickling__ check in REDUCE,
it doesn't matter whether this attribute has a true or false value, it it doesn't matter whether this attribute has a true or false value, it
only matters whether it exists (XXX this smells like a bug). If only matters whether it exists (XXX this is a bug; cPickle
__safe_for_unpickling__ dosn't exist, UnpicklingError is raised. requires the attribute to be true). If __safe_for_unpickling__
doesn't exist, UnpicklingError is raised.
Else (the class object does have a __safe_for_unpickling__ attr), Else (the class object does have a __safe_for_unpickling__ attr),
the class object obtained from INST's arguments is applied to the the class object obtained from INST's arguments is applied to the
@ -1624,8 +1636,9 @@ opcodes = [
As for INST, the remainder of the stack above the markobject is As for INST, the remainder of the stack above the markobject is
gathered into an argument tuple, and then the logic seems identical, gathered into an argument tuple, and then the logic seems identical,
except that no __safe_for_unpickling__ check is done (XXX this smells except that no __safe_for_unpickling__ check is done (XXX this is
like a bug). See INST for the gory details. a bug; cPickle does test __safe_for_unpickling__). See INST for
the gory details.
"""), """),
I(name='NEWOBJ', I(name='NEWOBJ',