Issue #1722344: threading._shutdown() is now called in Py_Finalize(), which

fixes the problem of some exceptions being thrown at shutdown when the
interpreter is killed. Patch by Adam Olsen.
This commit is contained in:
Antoine Pitrou 2009-10-20 21:29:37 +00:00
parent a7a52ab7ee
commit efb60c0ceb
5 changed files with 59 additions and 29 deletions

View file

@ -222,33 +222,6 @@ static int RunMainFromImporter(char *filename)
}
/* Wait until threading._shutdown completes, provided
the threading module was imported in the first place.
The shutdown routine will wait until all non-daemon
"threading" threads have completed. */
#include "abstract.h"
static void
WaitForThreadShutdown(void)
{
#ifdef WITH_THREAD
PyObject *result;
PyThreadState *tstate = PyThreadState_GET();
PyObject *threading = PyMapping_GetItemString(tstate->interp->modules,
"threading");
if (threading == NULL) {
/* threading not imported */
PyErr_Clear();
return;
}
result = PyObject_CallMethod(threading, "_shutdown", "");
if (result == NULL)
PyErr_WriteUnraisable(threading);
else
Py_DECREF(result);
Py_DECREF(threading);
#endif
}
/* Main program */
int
@ -624,8 +597,6 @@ Py_Main(int argc, char **argv)
sts = PyRun_AnyFileFlags(stdin, "<stdin>", &cf) != 0;
}
WaitForThreadShutdown();
Py_Finalize();
#ifdef RISCOS
if (Py_RISCOSWimpFlag)