mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-02 11:08:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

Issue 6032: fix refleaks in test_urllib2_localnet.

Browse source
This commit is contained in:
Collin Winter 2009-05-18 21:35:40 +00:00
parent 61328eef1f
commit f03c42f0ab
2 changed files with 22 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

38
Lib/test/test_urllib2_localnet.py
View file

@ -195,7 +195,11 @@ class FakeProxyHandler(BaseHTTPServer.BaseHTTPRequestHandler):
testing. testing.
""" """
digest_auth_handler = DigestAuthHandler() def __init__(self, digest_auth_handler, *args, **kwargs):
# This has to be set before calling our parent's __init__(), which will
# try to call do_GET().
self.digest_auth_handler = digest_auth_handler
BaseHTTPServer.BaseHTTPRequestHandler.__init__(self, *args, **kwargs)
def log_message(self, format, *args): def log_message(self, format, *args):
# Uncomment the next line for debugging. # Uncomment the next line for debugging.
@ -224,49 +228,50 @@ class ProxyAuthTests(unittest.TestCase):
REALM = "TestRealm" REALM = "TestRealm"
def setUp(self): def setUp(self):
FakeProxyHandler.digest_auth_handler.set_users({ self.digest_auth_handler = DigestAuthHandler()
self.USER : self.PASSWD self.digest_auth_handler.set_users({self.USER: self.PASSWD})
}) self.digest_auth_handler.set_realm(self.REALM)
FakeProxyHandler.digest_auth_handler.set_realm(self.REALM) def create_fake_proxy_handler(*args, **kwargs):
return FakeProxyHandler(self.digest_auth_handler, *args, **kwargs)
self.server = LoopbackHttpServerThread(FakeProxyHandler) self.server = LoopbackHttpServerThread(create_fake_proxy_handler)
self.server.start() self.server.start()
self.server.ready.wait() self.server.ready.wait()
proxy_url = "http://127.0.0.1:%d" % self.server.port proxy_url = "http://127.0.0.1:%d" % self.server.port
handler = urllib2.ProxyHandler({"http" : proxy_url}) handler = urllib2.ProxyHandler({"http" : proxy_url})
self._digest_auth_handler = urllib2.ProxyDigestAuthHandler() self.proxy_digest_handler = urllib2.ProxyDigestAuthHandler()
self.opener = urllib2.build_opener(handler, self._digest_auth_handler) self.opener = urllib2.build_opener(handler, self.proxy_digest_handler)
def tearDown(self): def tearDown(self):
self.server.stop() self.server.stop()
def test_proxy_with_bad_password_raises_httperror(self): def test_proxy_with_bad_password_raises_httperror(self):
self._digest_auth_handler.add_password(self.REALM, self.URL, self.proxy_digest_handler.add_password(self.REALM, self.URL,
self.USER, self.PASSWD+"bad") self.USER, self.PASSWD+"bad")
FakeProxyHandler.digest_auth_handler.set_qop("auth") self.digest_auth_handler.set_qop("auth")
self.assertRaises(urllib2.HTTPError, self.assertRaises(urllib2.HTTPError,
self.opener.open, self.opener.open,
self.URL) self.URL)
def test_proxy_with_no_password_raises_httperror(self): def test_proxy_with_no_password_raises_httperror(self):
FakeProxyHandler.digest_auth_handler.set_qop("auth") self.digest_auth_handler.set_qop("auth")
self.assertRaises(urllib2.HTTPError, self.assertRaises(urllib2.HTTPError,
self.opener.open, self.opener.open,
self.URL) self.URL)
def test_proxy_qop_auth_works(self): def test_proxy_qop_auth_works(self):
self._digest_auth_handler.add_password(self.REALM, self.URL, self.proxy_digest_handler.add_password(self.REALM, self.URL,
self.USER, self.PASSWD) self.USER, self.PASSWD)
FakeProxyHandler.digest_auth_handler.set_qop("auth") self.digest_auth_handler.set_qop("auth")
result = self.opener.open(self.URL) result = self.opener.open(self.URL)
while result.read(): while result.read():
pass pass
result.close() result.close()
def test_proxy_qop_auth_int_works_or_throws_urlerror(self): def test_proxy_qop_auth_int_works_or_throws_urlerror(self):
self._digest_auth_handler.add_password(self.REALM, self.URL, self.proxy_digest_handler.add_password(self.REALM, self.URL,
self.USER, self.PASSWD) self.USER, self.PASSWD)
FakeProxyHandler.digest_auth_handler.set_qop("auth-int") self.digest_auth_handler.set_qop("auth-int")
try: try:
result = self.opener.open(self.URL) result = self.opener.open(self.URL)
except urllib2.URLError: except urllib2.URLError:
@ -484,8 +489,7 @@ def test_main():
# the next line. # the next line.
#test_support.requires("network") #test_support.requires("network")
test_support.run_unittest(ProxyAuthTests) test_support.run_unittest(ProxyAuthTests, TestUrlopen)
test_support.run_unittest(TestUrlopen)
if __name__ == "__main__": if __name__ == "__main__":
test_main() test_main()

2
Misc/build.sh
View file

@ -67,7 +67,7 @@ REFLOG="build/reflog.txt.out"
# Note: test_XXX (none currently) really leak, but are disabled # Note: test_XXX (none currently) really leak, but are disabled
# so we don't send spam. Any test which really leaks should only # so we don't send spam. Any test which really leaks should only
# be listed here if there are also test cases under Lib/test/leakers. # be listed here if there are also test cases under Lib/test/leakers.
LEAKY_TESTS="test_(asynchat|cmd_line|docxmlrpc|dumbdbm|file|ftplib|httpservers|imaplib|popen2|socket|smtplib|sys|telnetlib|threadedtempfile|threading|threadsignals|urllib2_localnet|xmlrpc)" LEAKY_TESTS="test_(asynchat|cmd_line|docxmlrpc|dumbdbm|file|ftplib|httpservers|imaplib|popen2|socket|smtplib|sys|telnetlib|threadedtempfile|threading|threadsignals|xmlrpc)"
# Skip these tests altogether when looking for leaks. These tests # Skip these tests altogether when looking for leaks. These tests
# do not need to be stored above in LEAKY_TESTS too. # do not need to be stored above in LEAKY_TESTS too.