mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-14 22:01:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

bpo-38066: Hide internal Stream methods (GH-15762)

Browse source 
feed_eof(), feed_data(), set_exception(), and set_transport() are prefixed with underscore now.

https://bugs.python.org/issue38066
(cherry picked from commit 12c122ae95)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
This commit is contained in:
Miss Islington (bot) 2019-09-10 06:44:32 -07:00 • committed by GitHub
parent 5cf8155bbd
commit f12ff05bc0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 155 additions and 92 deletions
Download patch file Download diff file Expand all files Collapse all files

49
Lib/asyncio/streams.py
View file

@ -1133,9 +1133,9 @@ class _BaseStreamProtocol(FlowControlMixin, protocols.Protocol):
stream = self._stream
if stream is not None:
if exc is None:
stream.feed_eof()
stream._feed_eof()
else:
stream.set_exception(exc)
stream._set_exception(exc)
if not self._closed.done():
if exc is None:
self._closed.set_result(None)
@ -1147,12 +1147,12 @@ class _BaseStreamProtocol(FlowControlMixin, protocols.Protocol):
def data_received(self, data):
stream = self._stream
if stream is not None:
stream.feed_data(data)
stream._feed_data(data)
def eof_received(self):
stream = self._stream
if stream is not None:
stream.feed_eof()
stream._feed_eof()
if self._over_ssl:
# Prevent a warning in SSLProtocol.eof_received:
# "returning true from eof_received()
@ -1219,7 +1219,7 @@ class _StreamProtocol(_BaseStreamProtocol):
stream = self._stream
if stream is None:
return
stream.set_transport(transport)
stream._set_transport(transport)
stream._protocol = self
def connection_lost(self, exc):
@ -1351,6 +1351,11 @@ class Stream:
@property
def transport(self):
warnings.warn("Stream.transport attribute is deprecated "
"since Python 3.8 and is scheduled for removal in 3.10; "
"it is an internal API",
DeprecationWarning,
stacklevel=2)
return self._transport
def write(self, data):
@ -1366,7 +1371,7 @@ class Stream:
def _fast_drain(self):
# The helper tries to use fast-path to return already existing
# complete future object if underlying transport is not paused
#and actual waiting for writing resume is not needed
# and actual waiting for writing resume is not needed
exc = self.exception()
if exc is not None:
fut = self._loop.create_future()
@ -1450,6 +1455,14 @@ class Stream:
return self._exception
def set_exception(self, exc):
warnings.warn("Stream.set_exception() is deprecated "
"since Python 3.8 and is scheduled for removal in 3.10; "
"it is an internal API",
DeprecationWarning,
stacklevel=2)
self._set_exception(exc)
def _set_exception(self, exc):
self._exception = exc
waiter = self._waiter
@ -1467,6 +1480,14 @@ class Stream:
waiter.set_result(None)
def set_transport(self, transport):
warnings.warn("Stream.set_transport() is deprecated "
"since Python 3.8 and is scheduled for removal in 3.10; "
"it is an internal API",
DeprecationWarning,
stacklevel=2)
self._set_transport(transport)
def _set_transport(self, transport):
if transport is self._transport:
return
assert self._transport is None, 'Transport already set'
@ -1478,6 +1499,14 @@ class Stream:
self._transport.resume_reading()
def feed_eof(self):
warnings.warn("Stream.feed_eof() is deprecated "
"since Python 3.8 and is scheduled for removal in 3.10; "
"it is an internal API",
DeprecationWarning,
stacklevel=2)
self._feed_eof()
def _feed_eof(self):
self._eof = True
self._wakeup_waiter()
@ -1486,6 +1515,14 @@ class Stream:
return self._eof and not self._buffer
def feed_data(self, data):
warnings.warn("Stream.feed_data() is deprecated "
"since Python 3.8 and is scheduled for removal in 3.10; "
"it is an internal API",
DeprecationWarning,
stacklevel=2)
self._feed_data(data)
def _feed_data(self, data):
_ensure_can_read(self._mode)
assert not self._eof, 'feed_data after feed_eof'